feedback-manager: Deeply free the feedback list
Instead of freeing each elemnt after each iteration and then the list itself at the very end just fully free the list. g_autoslist does not work well on oder glib so do that manually. This is just...
View Articlefeedback-led: Don't try to stop led when there's no led device
This is not a critical since we prevented submitting initially but daemon cleanup processes all entries in the theme.
View Articlefbd-dev-leds: fix brightness parameter
The fbd_dev_led_set_brightness function is only getting called with parameter 0 at the moment so this was never noticed.
View Articlefbd-feedback-manager: Allow device-specific feedbackd themes
Reads the compatible list of the device and tries to find a device-specific theme file in all directories. If no configuration is found, we fall back to a default theme file. The device-specific theme...
View Articlefeedback-manager: Fix formatting
It was off in several places. Now that there's no outstanding MRs clean it up via uncrustify --replace -c phosh.cfg src/fbd-feedback-manager.c
View Articleimplement fbd_dev_sound_stop
tracks the FdbFeedbackSounds in a GHashTable in the FdbDevSound
View Articlefbd-ledctrl: fix matching of trigger in list of triggers
If the trigger is the last thing in sysfs_path/LED_TRIGGER_ATTR, then the new-line at the end of the output causes g_strv_contains to fail to find the trigger in the list. This strips the new-line...
View Articlefeedback-manager: Track DBus clients and end feedbacks if they go away
When the client goes away we build up a list of events to end feedback for to make sure the hash table isn't modified in place. tThe alternative approach would be to disconnect the...
View Articlefbd-dev-leds: Use automatic deep cleanup for device list
The current logic was fragile and failed e.g. when the FEEDBACKD_UDEV_VAL_LED would not match leaking the dev since the g_object_unref() at the end of the loop was never hit. Prevent that with...
View Articlefbd-dev-sound: Use correct cleanup for hash table
This went unnoticed since the manager forgot to cleanup this at all (see follow up commit).
View Articlefbd-feedback-manager: Make sure theme path components are '/' separated
Previously, assembly of the theme paths for custom paths (based on `XDG_DATA_DIRS`) was performed using `g_strconcat`, which produced erroneous file paths with missing path separators due to a typo in...
View ArticleClik here to view.
feedback-manager: Search for default theme under XDG_CONFIG_HOME first
This would allow users to create their own feedback profiles without editing system files or using root privileges Signed-off-by: Pablo Correa Gómez<ablocorrea@hotmail.com>
View Articlefbd-dev-sound: Honour sound theme name for all GNOME based desktops
Phosh recently changed to XDG_CURRENT_DESKTOP=GNOME:Phosh and has since stopped using the configured theme and instead used the fallback freedesktop theme. Closes #41
View Articlefbd-dev-sounce: Name data consistently
We name it `data` elsewhere. Don't call it `object` in one function.
View Articlefbd-dev-sound: Delay sending `ended` signal
Remove the feedback and the associated callback data before invoking the callback (which then triggers FbdFeebackBased:ended) since we otherwise remove the data from the currently playing sound from...
View ArticleReload theme on SIGHUP signal
Fixes #28 Allows for users/applications to request a theme reload by sending SIGHUP signal to the daemon.
View Articlemanager: Set initial profile to unknown
This makes sure we sync the profile with the DBus property after fetching it from GSettings.
View Articlemanager: Sync profile with setting on startup
On startup the GSetting is the relevant input for selecting the profle. Closes: #52
View Article