Quantcast
Channel: feedbackd:5c8cbfca399e24c4aa029591cdf671f5e2c9f5bc commits
Browsing all 40 articles
Browse latest View live
↧

feedback-manager: Deeply free the feedback list

Instead of freeing each elemnt after each iteration and then the list itself at the very end just fully free the list. g_autoslist does not work well on oder glib so do that manually. This is just...

View Article


feedback-manager: Don't forget to remove not found events from the hash table

This plugs a leak.

View Article


feedback-manager: Dispose leds too

View Article

feedback-led: Stop the correct led color

View Article

feedback-led: Don't try to stop led when there's no led device

This is not a critical since we prevented submitting initially but daemon cleanup processes all entries in the theme.

View Article


fbd: Dispose manager at the very end

View Article

sound: Set 'event' media role

This allows pa to cork, duck, etc.

View Article

fbd-dev-leds: fix brightness parameter

The fbd_dev_led_set_brightness function is only getting called with parameter 0 at the moment so this was never noticed.

View Article


Fix typos

View Article


fbd-feedback-manager: Allow device-specific feedbackd themes

Reads the compatible list of the device and tries to find a device-specific theme file in all directories. If no configuration is found, we fall back to a default theme file. The device-specific theme...

View Article

feedback-manager: Fix formatting

It was off in several places. Now that there's no outstanding MRs clean it up via uncrustify --replace -c phosh.cfg src/fbd-feedback-manager.c

View Article

implement fbd_dev_sound_stop

tracks the FdbFeedbackSounds in a GHashTable in the FdbDevSound

View Article

fbd-dev-sound: Don't leak GError

View Article


fbd-dev-sound: Don't warn when sound was cancelled

This is not an error per se.

View Article

fbd-ledctrl: fix matching of trigger in list of triggers

If the trigger is the last thing in sysfs_path/LED_TRIGGER_ATTR, then the new-line at the end of the output causes g_strv_contains to fail to find the trigger in the list. This strips the new-line...

View Article


event: Make log-domain match source file name

View Article

event: Remove 'g' prefix from common C types

This matchs phosh's style.

View Article


fbd-event: Add sender property

This allows us to store the DBus sender

View Article

fbd-manager: Keep DBus sender around

View Article

feedback-manager: Track DBus clients and end feedbacks if they go away

When the client goes away we build up a list of events to end feedback for to make sure the hash table isn't modified in place. tThe alternative approach would be to disconnect the...

View Article
Browsing all 40 articles
Browse latest View live